grimar added a comment. In D68943#1710525 <https://reviews.llvm.org/D68943#1710525>, @MaskRay wrote:
> In D68943#1709998 <https://reviews.llvm.org/D68943#1709998>, @grimar wrote: > > > Ok, I was able to debug it finally. > > > > I think we should add a .symtab in a few more cases implicitly. > > For example, when we have a SHT_RELA/SHT_REL section that has an empty > > Link, > > i.e. it refers to .symtab by default and we should provide it. > > There are other cases, like when Link just explicitly refers to .symtab. > > > > Here is a patch based on this one. > > It is unpolished, but shows the idea. With it all yaml2obj tests pass. > > > > F10276544: patch.diff <https://reviews.llvm.org/F10276544> > > > Nice! Can you post a differential for the yaml2obj change? I believe the > differential can focus on lldb and remove yaml2obj changes (kwk will still > get credited for the test cleanups). Yes. It needs polishing + fixes for obj2yaml (I do not think it compiled for me at all). Also probably makes sence to add tests for obj2yaml too, I need to take a look what it does when the object doesn't have symbol table with such change. I'll try to suggest a patch today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
