lawrence_danna marked an inline comment as done.
lawrence_danna added inline comments.
================
Comment at: lldb/include/lldb/Host/File.h:56
static bool DescriptorIsValid(int descriptor) { return descriptor >= 0; };
+ static const char *GetStreamOpenModeFromOptions(uint32_t options);
----------------
labath wrote:
> change the argument type to OpenOptions. For some reason, lldb has
> historically used integer types for passing enumerations around, but we're
> now slowly changing that..
Are you sure that's the right thing to do? `eOpenOptionRead |
eOpenOptionWrite` has type `unsigned int`, not `OpenOptions`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68737/new/
https://reviews.llvm.org/D68737
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
