teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM. Also, this whole function seems to have no tests. So if you find an easy way to test this, then please add a test to `functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py`. You can also check this in as-is if the test turns out to be too complicated (I'm not a big fan of the whole "you touched my spaghetti so you also have to come up with a way to test the whole thing".) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68638/new/ https://reviews.llvm.org/D68638 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
