JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/API/SBCommandReturnObject.cpp:296 + (FileSP), file_sp); + return SetImmediateOutputFile(SBFile(file_sp)); +} ---------------- I'd drop the return. ================ Comment at: lldb/source/API/SBCommandReturnObject.cpp:302 + (FileSP), file_sp); + return SetImmediateErrorFile(SBFile(file_sp)); } ---------------- Same here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
