JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGTM with the `g_` prefixes removed. ================ Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4199 if (symbol_name_ref.startswith("_OBJC_")) { - static const llvm::StringRef g_objc_v2_prefix_class( + llvm::StringRef g_objc_v2_prefix_class( "_OBJC_CLASS_$_"); ---------------- Looks like this is the same string as above. I believe it's in scope, so we should be able to just reuse it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68597/new/ https://reviews.llvm.org/D68597 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits