labath added a comment. I like the idea of passing the variable values "inline". The MAKECMDGOALS thingy seems... clever. I sort of like it, and it also feels like it might be too much. I suppose that is fine, but.. do we actually need a functional clean rule? I was under the impression that ever since we moved tests to build out-of-tree the clean rule doesn't do much and isn't even being invoked by default. Should we just delete the clean rules altogether? The handful of tests that actually want to clean and rebuild as a part of the test can do something custom...
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68558/new/ https://reviews.llvm.org/D68558 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
