thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.
I noticed a bunch of explicit `llvm::` prefixes like `llvm::Error`,
`llvm::StringRef`, etc. Did you intentionally leave that there?
Otherwise, this LGTM, thanks for the nice cleanup!
================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:161
+ "standard input cannot be used as input for a dSYM update.",
+ inconvertibleErrorCode());
+ }
----------------
Would it make sense for all these error codes to be
`std::errc::invalid_argument`?
================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:233
+ getInputs(Args, Options.LinkOptions.Update)) {
+ Options.InputFiles = *InputFiles;
+ } else {
----------------
`= std::move(*InputFiles);`?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68361/new/
https://reviews.llvm.org/D68361
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
