kwk planned changes to this revision.
kwk added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731
Section *symtab =
section_list->FindSectionByType(eSectionTypeELFSymbolTable,
true).get();
- if (!symtab) {
- // The symtab section is non-allocable and can be stripped, so if it
- // doesn't exist then use the dynsym section which should always be
- // there.
- symtab =
- section_list->FindSectionByType(eSectionTypeELFDynamicSymbols, true)
- .get();
- }
if (symtab) {
m_symtab_up.reset(new Symtab(symtab->GetObjectFile()));
symbol_id += ParseSymbolTable(m_symtab_up.get(), symbol_id, symtab);
}
----------------
kwk wrote:
> labath wrote:
> > Let's put this bit into a separate patch. As I said over IRC, I view this
> > bit as functionally independent of the debugdata stuff (it's definitely
> > independent in it's current form, as it will kick in for non-debugdata
> > files too, which I think is fine).
> Done in D67390.
We agreed to not have this other patch. See D67390#1691424.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66791/new/
https://reviews.llvm.org/D66791
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
