labath added a comment. In D68188#1691337 <https://reviews.llvm.org/D68188#1691337>, @lawrence_danna wrote:
> In D68188#1691129 <https://reviews.llvm.org/D68188#1691129>, @labath wrote: > > > Then depending on what you need, you create either a NativeFile, > > OwningPythonFile<NativeFile>, or a Text/BinaryPythonFile. How does that > > sound? > > > Next step is add type maps to convert these things back to python. Without > the CRTP it can’t just check for a single OwnedPythonfile base class — it’ll > have to check for all three. Is that worse than using CRTP? Hmm... hard to say without knowing more details, but I would say that being worse than CRTP is quite hard. :) Also, Text and Binary python file will have OwningPythonFile<File> as their base, so you can check for those together. I'd say we go with this first, and then revisit if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
