teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
A few short comments what the role of the different classes/members play in the
test case would be helpful. E.g. "This member/variable/expressions triggers the
loading of Decl Foo in that CU". I'll take a closer look tomorrow, but on the
first looks this patch LGTM. Thanks!
================
Comment at:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2
+"""
+Test that we can call C++ template fucntions.
+"""
----------------
That comment is still from the original test case.
================
Comment at:
packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/other.cpp:9
+WrapperB* foo() {
+ return new WrapperB();
+}
----------------
nit pick: there are two spaces between `return` and `new` (we sadly don't use
clang-format for tests)
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68278/new/
https://reviews.llvm.org/D68278
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
