labath added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1 +MAKE_DSYM := NO + ---------------- jankratochvil wrote: > jankratochvil wrote: > > labath wrote: > > > I'm pretty sure this line is not needed. > > Removed in current testsuite: rL373061 > So I do not understand how `MAKE_DSYM` works but global removal of `MAKE_DSYM > := NO` in rL373061 broke OSX so I have reverted it by rL373110. Keeping > `MAKE_DSYM := NO` stays omitted for this testcase. Yeah, the test which failed is doing pretty funky stuff, so I can imagine it can get hurt by removing MAKE_DSYM. Omitting it for this test should be safe though. (Probably all other tests except TestFunctionStarts.py too, but I don't think you have to bother with that.) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
