shafik added inline comments.
================ Comment at: clang/include/clang/AST/ExternalASTMerger.h:92 ImporterTarget Target; + std::shared_ptr<ASTImporterSharedState> SharedState; ---------------- Can you add a comment explaining what this is and why we need it and how it relates to the `ASTImpoter`. It is not obvious just looking the local changes what effect adding this has. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68140/new/ https://reviews.llvm.org/D68140 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
