kwk added a comment.
Interesting. It looks like we indeed have a test (the only one failing atm.)
that wants a symbol to be added twice:
[ RUN ] MangledTest.NameIndexes_FindFunctionSymbols
/home/kkleine/llvm/lldb/unittests/Core/MangledTest.cpp:186: Failure
Expected: 1
To be equal to: Count("puts@GLIBC_2.6", eFunctionNameTypeFull)
Which is: 0
/home/kkleine/llvm/lldb/unittests/Core/MangledTest.cpp:187: Failure
Expected: 2
To be equal to: Count("puts", eFunctionNameTypeFull)
Which is: 1
/home/kkleine/llvm/lldb/unittests/Core/MangledTest.cpp:188: Failure
Expected: 2
To be equal to: Count("puts", eFunctionNameTypeBase)
Which is: 1
[ FAILED ] MangledTest.NameIndexes_FindFunctionSymbols (1 ms)
Before I used the bare symbol name with stripped `@VERSION` suffix. Now I've
changed the implementation of `NamedELFSymbol` to include the `@VERSION`
suffix. Is that fine?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67390/new/
https://reviews.llvm.org/D67390
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
