jankratochvil added a comment.

In D67390#1681034 <https://reviews.llvm.org/D67390#1681034>, @kwk wrote:

>   I wonder how to define uniqueness for them. As you can see, the only 
> difference is the symbol section which wasn't part of your definition of 
> uniqueness (yet).


These symbols should be obviously all kept distinct.  Yes, you should add to 
the tuple also `ELFSymbol::st_shndx` as I have seen in your code: 
https://people.redhat.com/jkratoch/kwk-branch.diff


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67390/new/

https://reviews.llvm.org/D67390



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to