mstorsjo marked an inline comment as done. mstorsjo added inline comments.
================ Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ ---------------- hhb wrote: > Maybe move these into the defined(_MSC_VER) above? Or the other way? Seems > they should be consistent. I don't want to move them into the `_MSC_VER` ifdef above, as there are pretty recent mingw-w64 releases without these new defines as well (the new ones were only added in mingw-w64 v4), but I guess I could change the `_MSC_VER` ifdef to check for `S_IRUSR` instead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67910/new/ https://reviews.llvm.org/D67910 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
