mstorsjo created this revision.
mstorsjo added reviewers: amccarth, compnerd, hhb.
Herald added subscribers: JDevlieghere, abidh, mgorny.
Herald added a project: LLDB.
The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it
has to be linked in anywhere.
Current MSVC based builds have probably succeeded, as other parts in LLDB have
had a "#pragma comment(lib, "dbghelp.lib")", but there's currently no such
pragma in the PECOFF plugin.
The "#pragma comment(lib, ...)" approach doesn't work in MinGW mode (unless the
compiler is given the -fms-extensions option, and even then, it's only
supported by clang/lld, not by GCC/binutils), thus add it to be linked via
CMake. (The other parts of LLDB that use dbghelp are within _MSC_VER ifdefs.)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D67885
Files:
lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
Index: lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
===================================================================
--- lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
+++ lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
@@ -1,3 +1,9 @@
+if(WIN32)
+ set(DBGHELP_LINK_FILES dbghelp)
+else()
+ set(DBGHELP_LINK_FILES "")
+endif()
+
add_lldb_library(lldbPluginObjectFilePECOFF PLUGIN
ObjectFilePECOFF.cpp
WindowsMiniDump.cpp
@@ -7,6 +13,7 @@
lldbHost
lldbSymbol
lldbTarget
+ ${DBGHELP_LINK_FILES}
LINK_COMPONENTS
BinaryFormat
Support
Index: lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
===================================================================
--- lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
+++ lldb/source/Plugins/ObjectFile/PECOFF/CMakeLists.txt
@@ -1,3 +1,9 @@
+if(WIN32)
+ set(DBGHELP_LINK_FILES dbghelp)
+else()
+ set(DBGHELP_LINK_FILES "")
+endif()
+
add_lldb_library(lldbPluginObjectFilePECOFF PLUGIN
ObjectFilePECOFF.cpp
WindowsMiniDump.cpp
@@ -7,6 +13,7 @@
lldbHost
lldbSymbol
lldbTarget
+ ${DBGHELP_LINK_FILES}
LINK_COMPONENTS
BinaryFormat
Support
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
