[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo created this revision.
mstorsjo added reviewers: asmith, hhb, labath.
Herald added a subscriber: JDevlieghere.
Herald added a project: LLDB.

This fixes a warning when built with Clang instead of MSVC.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D67860

Files:
  lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp


Index: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
===================================================================
--- lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
+++ lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
@@ -479,7 +479,7 @@
       return ExceptionResult::BreakInDebugger;
     }
 
-    // Fall through
+    LLVM_FALLTHROUGH;
   default:
     LLDB_LOG(log,
              "Debugger thread reported exception {0:x} at address {1:x} "



Index: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
===================================================================
--- lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
+++ lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
@@ -479,7 +479,7 @@
       return ExceptionResult::BreakInDebugger;
     }
 
-    // Fall through
+    LLVM_FALLTHROUGH;
   default:
     LLDB_LOG(log,
              "Debugger thread reported exception {0:x} at address {1:x} "

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits