JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+ eAppleObjCDeclVendor,
+ eLastClangDeclVendor,
+ };
----------------
What's `eLastClangDeclVendor` and where is it used?
================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h:33
+ static bool classof(const DeclVendor *vendor) {
+ return vendor->GetKind() >= eClangDeclVendor &&
+ vendor->GetKind() < eLastClangDeclVendor;
----------------
I think a switch would be more readable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66451/new/
https://reviews.llvm.org/D66451
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
