mib marked 18 inline comments as done.
mib added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/fast_conditional_breakpoints/TestFastConditionalBreakpoints.py:51
+ if cli == True:
+ lldbutil.run_break_set_by_source_regexp(
+ self, self.comment, self.extra_options
----------------
JDevlieghere wrote:
> Did you copy this code style from somewhere? If so it's fine, but otherwise
> I'd stick to the common style. I think the "great refactor" commit includes
> the command used to format the tests. I use `yapf` for Python but it doesn't
> exactly match.
I used Python's Black formatter, because I wasn't aware of the "great refactor"
command: `find . -iname "*.py" -exec autopep8 --in-place --aggressive
--aggressive {} + ;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66248/new/
https://reviews.llvm.org/D66248
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
