clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/include/lldb/lldb-enumerations.h:170
// etc...
+ eFormatUnicode8,
eFormatUnicode16,
----------------
add to the end, or all LLDBRPC.framework calls that use this enumeration will
fail for you.
================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:1383-1384
+ streq(type_name, "wchar") || // dlang
+ streq(type_name, "const(wchar)") ||
+ streq(type_name, "immutable(wchar)")) {
return CompilerType(this, ast->Char16Ty.getAsOpaquePtr());
----------------
are "const(T)" and "immutable(T)" the actualy type names or are they layers on
top of a base "wchar" type? These shouldn't be needed if so as the base "wchar"
type should end up handling the base type correctly. Remove?
================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:1388-1389
+ streq(type_name, "dchar") || // dlang
+ streq(type_name, "const(dchar") ||
+ streq(type_name, "immutable(dchar)")) {
return CompilerType(this, ast->Char32Ty.getAsOpaquePtr());
----------------
ditto
================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:1393-1394
+ streq(type_name, "char") || // dlang
+ streq(type_name, "const(char)") ||
+ streq(type_name, "immutable(char)")) {
+ return CompilerType(this, ast->Char8Ty.getAsOpaquePtr());
----------------
ditto
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66447/new/
https://reviews.llvm.org/D66447
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
