labath added a comment.

I have one high-level question. Who is generating the code inside the 
"trampoline" object file? Couldn't we have him generate proper unwind 
information so that the regular unwind machinery "just works"? I imagine all it 
would take is a couple of well-placed `.cfi` assembler directives...



================
Comment at: lldb/source/Target/ABI.cpp:10
 #include "lldb/Target/ABI.h"
+#include "Plugins/ObjectFile/Trampoline/ObjectFileTrampoline.h"
+#include "lldb/Core/Module.h"
----------------
If this is going to be something that is called directly from core lldb code, 
then it not a "plugin" by any stretch of imagination. I think we should put 
this file some place else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66250/new/

https://reviews.llvm.org/D66250



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to