teemperor added a comment. Could you expand the test (or add another test) for completing in an anonymous classes? Otherwise this LGTM beside Adrian comments assuming this fixes the crash.
================ Comment at: packages/Python/lldbsuite/test/expression_command/completion-crash-lambda/TestCompletionCrashInLambda.py:4 -lldbinline.MakeInlineTest(__file__, globals(), [decorators.skipIf(bugnumber="rdar://53755023")]) +lldbinline.MakeInlineTest(__file__, globals(), []) ---------------- aprantl wrote: > Can you rename that test to not contain the word "crash" and instead describe > the action being performed? > (CompletionOfLambda or something like that should be fine) You an actually completely remove the decorators import and the empty `[]`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66175/new/ https://reviews.llvm.org/D66175 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
