sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

It seems conceptually a little strange to have the working directory be part of 
a serialized "FS", as it's fundamentally a property of a process and only 
transiently a property of the VFS.
I don't know this is fatal (not sure what else the RedirectingFileSystem might 
be used for.

What's the reason to store this as part of the VFS rather than as a separate 
attribute of the larger reproducer structure?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65677/new/

https://reviews.llvm.org/D65677



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to