jfb requested changes to this revision.
jfb added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737
+ for (auto it = m_threads.begin(); it != m_threads.end(); ++it) {
+ if (*it && ((*it)->GetID() == thread_id)) {
+ m_threads.erase(it);
----------------
mgorny wrote:
> labath wrote:
> > It looks like the rest of the code assumes (as I think it should) that the
> > thread list does not contain null pointers. See e.g. the loop on line 276.
> For the record, I've copied it from Linux ;-P.
Are you serious? Because you absolutely cannot copy code from Linux into LLVM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65555/new/
https://reviews.llvm.org/D65555
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
