mgorny updated this revision to Diff 211787.
mgorny added a comment.
Herald added a reviewer: jfb.
Un-XFAIL some tests fixed by this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65289/new/
https://reviews.llvm.org/D65289
Files:
lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
===================================================================
--- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
+++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
@@ -203,6 +203,7 @@
SIGSTOP, &info.psi_siginfo);
}
}
+ SetState(StateType::eStateStopped, true);
}
}
Index:
lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
===================================================================
---
lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
+++
lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
@@ -194,7 +194,6 @@
oslist=["windows"],
bugnumber="llvm.org/pr24668: Breakpoints not resolved correctly")
@skipIfDarwin # llvm.org/pr15824 thread states not properly maintained and
<rdar://problem/28557237>
- @expectedFailureNetBSD
@no_debug_info_test
def test_process_interrupt(self):
"""Test process interrupt and continue."""
Index:
lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
+++ lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
@@ -26,7 +26,6 @@
oslist=['freebsd'],
bugnumber="llvm.org/pr23318: does not report running state")
@skipIfWindows # Windows does not support signals
- @expectedFailureNetBSD
def test_with_run_command(self):
"""Test that lldb command 'process signal SIGUSR1' sends a signal to
the inferior process."""
self.build()
Index:
lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
===================================================================
---
lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
+++
lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
@@ -27,7 +27,6 @@
oslist=[
"windows"],
bugnumber="llvm.org/pr21765")
- @expectedFailureNetBSD
def test(self):
"""Test calling std::String member function."""
self.build()
Index:
lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
===================================================================
---
lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
+++
lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
@@ -26,7 +26,6 @@
@skipIfFreeBSD # llvm.org/pr19246: intermittent failure
@skipIfDarwin # llvm.org/pr19246: intermittent failure
@skipIfWindows # Test relies on signals, unsupported on Windows
- @expectedFailureNetBSD
@expectedFlakeyAndroid(bugnumber="llvm.org/pr19246")
def test(self):
"""Test calling function that hits a signal and restarts."""
Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
===================================================================
--- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
+++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
@@ -203,6 +203,7 @@
SIGSTOP, &info.psi_siginfo);
}
}
+ SetState(StateType::eStateStopped, true);
}
}
Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
+++ lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
@@ -194,7 +194,6 @@
oslist=["windows"],
bugnumber="llvm.org/pr24668: Breakpoints not resolved correctly")
@skipIfDarwin # llvm.org/pr15824 thread states not properly maintained and <rdar://problem/28557237>
- @expectedFailureNetBSD
@no_debug_info_test
def test_process_interrupt(self):
"""Test process interrupt and continue."""
Index: lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
+++ lldb/packages/Python/lldbsuite/test/functionalities/signal/TestSendSignal.py
@@ -26,7 +26,6 @@
oslist=['freebsd'],
bugnumber="llvm.org/pr23318: does not report running state")
@skipIfWindows # Windows does not support signals
- @expectedFailureNetBSD
def test_with_run_command(self):
"""Test that lldb command 'process signal SIGUSR1' sends a signal to the inferior process."""
self.build()
Index: lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
+++ lldb/packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
@@ -27,7 +27,6 @@
oslist=[
"windows"],
bugnumber="llvm.org/pr21765")
- @expectedFailureNetBSD
def test(self):
"""Test calling std::String member function."""
self.build()
Index: lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
+++ lldb/packages/Python/lldbsuite/test/expression_command/call-restarts/TestCallThatRestarts.py
@@ -26,7 +26,6 @@
@skipIfFreeBSD # llvm.org/pr19246: intermittent failure
@skipIfDarwin # llvm.org/pr19246: intermittent failure
@skipIfWindows # Test relies on signals, unsupported on Windows
- @expectedFailureNetBSD
@expectedFlakeyAndroid(bugnumber="llvm.org/pr19246")
def test(self):
"""Test calling function that hits a signal and restarts."""
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
