Author: xiaobai Date: Mon Jul 22 17:41:00 2019 New Revision: 366771 URL: http://llvm.org/viewvc/llvm-project?rev=366771&view=rev Log: [lldb][test_suite] Fix skipIfTargetAndroid decorator
Summary: Delete the duplicate func `skipIfTargetAndroid` Fix the old one. It didn't work for missing an argument `bugnumber`, this somehow made the decorator failed Differential Revision: https://reviews.llvm.org/D64583 Patch by Wanyi Ye <kusm...@gmail.com> Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/decorators.py?rev=366771&r1=366770&r2=366771&view=diff ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/decorators.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/decorators.py Mon Jul 22 17:41:00 2019 @@ -596,11 +596,6 @@ def skipIfWindows(func): """Decorate the item to skip tests that should be skipped on Windows.""" return skipIfPlatform(["windows"])(func) -def skipIfTargetAndroid(func): - return unittest2.skipIf(lldbplatformutil.target_is_android(), - "skip on target Android")(func) - - def skipUnlessWindows(func): """Decorate the item to skip tests that should be skipped on any non-Windows platform.""" return skipUnlessPlatform(["windows"])(func) @@ -652,7 +647,7 @@ def skipUnlessPlatform(oslist): "requires one of %s" % (", ".join(oslist))) -def skipIfTargetAndroid(api_levels=None, archs=None): +def skipIfTargetAndroid(bugnumber=None, api_levels=None, archs=None): """Decorator to skip tests when the target is Android. Arguments: @@ -665,7 +660,8 @@ def skipIfTargetAndroid(api_levels=None, _skip_for_android( "skipping for android", api_levels, - archs)) + archs), + bugnumber) def skipUnlessSupportedTypeAttribute(attr): """Decorate the item to skip test unless Clang supports type __attribute__(attr).""" _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
