sgraenitz marked 2 inline comments as done. sgraenitz added inline comments.
================ Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50 - -option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF) -option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver instead of building it from source (Darwin only)." OFF) ---------------- sgraenitz wrote: > sgraenitz wrote: > > xiaobai wrote: > > > Could we actually preserve `LLDB_NO_DEBUGSERVER`? After pulling this > > > patch down into my tree and modifying my caches, I realize that I never > > > really change or test debugserver and would like to avoid building it at > > > all. > > This should be equivalent to `-DLLDB_TOOL_DEBUGSERVER_BUILD=OFF` > Ok this is a different issue. I guess we should align these: > ``` > if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > add_subdirectory(darwin-debug) > add_subdirectory(debugserver) > endif() > > if (LLDB_CAN_USE_LLDB_SERVER) > add_lldb_tool_subdirectory(lldb-server) > endif() > ``` https://reviews.llvm.org/D64994 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64806/new/ https://reviews.llvm.org/D64806 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
