teemperor marked an inline comment as done.
teemperor added a comment.

In D64365#1574785 <https://reviews.llvm.org/D64365#1574785>, @jingham wrote:

> Do you know how you are going to do enum option values?


We could implement the enums in our table gen file, but then we would have the 
enums duplicated in code and table gen (unless we also table gen the enum 
definition). At the moment I'm just using plain strings in table gen which then 
get type checked by Clang during compilation. The *.inc file should have enough 
comments in it that it should be trivial to find out in what option definition 
you made a typo.

But I'm open to suggestions how to make this more user-friendly if people 
encounter problems with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64365/new/

https://reviews.llvm.org/D64365



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to