davide added inline comments.
================ Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { - // BAD!!! + assert(false && "GetUniqueNamespaceDeclaration called with no name and " + "no namespace as decl_ctx"); ---------------- davide wrote: > shafik wrote: > > We don't have a way to trigger this branch? > I guess this is the whole point of the assertion. It can't be hit. BTW, you > can replace it with `llvm_unreachable()` "can't" in this context is a very strong word. It shouldn't. If it gets hit, we should remove the assertion. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57880/new/ https://reviews.llvm.org/D57880 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits