jingham marked 2 inline comments as done.
jingham added inline comments.
================
Comment at: source/Target/Process.cpp:3037-3041
+ // Somebody might have gotten threads before now, but we need to force the
+ // update after we've loaded the OperatingSystem plugin or it won't get a
+ // chance to process the threads.
+ m_thread_list.Clear();
+ UpdateThreadListIfNeeded();
----------------
clayborg wrote:
> Should this be in the above if statement?
>
> ```
> if (!m_os_up) {
> LoadOperatingSystemPlugin(false);
> // Somebody might have gotten threads before now, but we need to force the
> // update after we've loaded the OperatingSystem plugin or it won't get a
> // chance to process the threads.
> m_thread_list.Clear();
> UpdateThreadListIfNeeded();
> }
> ```
>
> And if we do this in the if statement, do we need to clear the m_thread_list?
You're right. Actually, we should try to get the OS plugin and only if we
succeed do we need to do any work. I changed the code to do that.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62887/new/
https://reviews.llvm.org/D62887
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
