[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha created this revision.
tatyana-krasnukha added a reviewer: hintonda.
tatyana-krasnukha added a project: LLDB.
Herald added subscribers: lldb-commits, mgorny, ki.stfu.

Using $<TARGET_OBJECTS:...> in anything other than add_library and 
add_executable was not supported until cmake 3.9.
The issue was added with https://reviews.llvm.org/D55653.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D63544

Files:
  tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt


Index: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
===================================================================
--- tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
+++ tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
@@ -9,5 +9,11 @@
     Support
   )
 
-target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
+if(${CMAKE_VERSION} VERSION_LESS "3.9.0")
+  add_library(ObjLibWrapper SHARED $<TARGET_OBJECTS:lldb-mi-utils>)
+  target_link_libraries(LLDBMiUtilTests PRIVATE ObjLibWrapper)
+else()
+  target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
+endif()
+
 set_target_properties(lldb-mi-utils PROPERTIES FOLDER "lldb libraries")



Index: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
===================================================================
--- tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
+++ tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt
@@ -9,5 +9,11 @@
     Support
   )
 
-target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
+if(${CMAKE_VERSION} VERSION_LESS "3.9.0")
+  add_library(ObjLibWrapper SHARED $<TARGET_OBJECTS:lldb-mi-utils>)
+  target_link_libraries(LLDBMiUtilTests PRIVATE ObjLibWrapper)
+else()
+  target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
+endif()
+
 set_target_properties(lldb-mi-utils PROPERTIES FOLDER "lldb libraries")

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits