JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Core/Debugger.cpp:124
+#define FILE_COLOR "${ansi.fg.yellow}"
+#define STOP_COLOR "${ansi.fg.red}$"
+
----------------
aprantl wrote:
> Thanks, but I was thinking more about something that could be replaced 
> dynamically to support dark and light terminals in the same LLDB binary. Int 
> hits form, this probably doesn't add much because ...
As discussed offline, I think it's better to have fixed colors (but not things 
like black and white) and let the user's color scheme deal with their 
interpretation. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62743/new/

https://reviews.llvm.org/D62743



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to