[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

I suppose one could compile Objective-C code on Linux using GCC.



================
Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:255
+          bool is_objc_method = false;
+          if (check_objc) {
+            ObjCLanguage::MethodName objc_method(name, true);
----------------
Since check_objc is only used here, I think it would be better for readability 
to say 
```
if (cu_language == eLanguageTypeObjC ||
    cu_language == eLanguageTypeObjC_plus_plus)
```
here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63171/new/

https://reviews.llvm.org/D63171



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits