stella.stamenova accepted this revision.
stella.stamenova added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/lit/CMakeLists.txt:13
+ # Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided
+ # LLVM build-tree used a single-configuration generator like Ninja.
+ string(REPLACE ${CMAKE_CFG_INTDIR} "." LLDB_DOTEST_ARGS
"${LLDB_DOTEST_ARGS}")
----------------
sgraenitz wrote:
> stella.stamenova wrote:
> > It looks like you need the update here also. Is there a way to share the
> > logic between the two cmake files?
> >
> > You probably no longer need the xcode pivot either, right?
> Thanks for catching this one! Ok deal, I remove the Xcode restriction and you
> run a test with VS? ;)
I can run some tests with VS, probably tomorrow though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62859/new/
https://reviews.llvm.org/D62859
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
