compnerd added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:145
+ switch (ArchType) {
+ case Triple::ArchType::aarch64:
+ return CPUType::ARM64;
----------------
I that `aarch64_be` and `aarch64_32` should be included in this.
================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:147
+ return CPUType::ARM64;
+ default:
+ return CPUType::X64;
----------------
This is still wrong. `x86` and `armv7` are totally legitimate values.
Furthermore, x86 is still far more prevalent on Windows.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62812/new/
https://reviews.llvm.org/D62812
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
