aprantl added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:114
+static inline bool AddMangled(const char *name, const char *mangled) {
+ if (mangled == nullptr || name == mangled)
+ return false;
----------------
Even in a static function I feel weird comparing two char* by pointer value.
Can you use llvm::StringRefs instead? then we don't need to call the unsafe
strcmp either and just trust that operator== is implemented efficiently.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62756/new/
https://reviews.llvm.org/D62756
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
