labath accepted this revision. labath added inline comments.
================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:724 uint32_t curr_depth) const { - const DWARFAbbreviationDeclaration *abbrevDecl = nullptr; - lldb::offset_t offset = 0; - if (cu) - abbrevDecl = GetAbbreviationDeclarationPtr(cu, offset); - + auto abbrevDecl = GetAbbreviationDeclarationPtr(cu); if (abbrevDecl) { ---------------- It would be better to say `auto *abbrevDecl` here. The extra char doesn't cost much, and it saves one from wondering whether there is anything fancy going on behind the scenes <http://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto> CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62634/new/ https://reviews.llvm.org/D62634 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits