clayborg added a comment.
overall looks good. See inlined comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:929-938
+ llvm::DWARFDebugLine line;
+ llvm::Expected<const llvm::DWARFDebugLine::LineTable *> line_table =
+ line.getOrParseLineTable(
+ data, offset, *ctx, ctx->getUnitForOffset(dwarf_cu->GetOffset()),
+ [](llvm::Error e) { llvm::consumeError(std::move(e)); });
+
+ if (!line_table) {
----------------
Can we make a function out of this that just returns the "const
llvm::DWARFDebugLine::LineTable *"? Or make a new location variable that is
just a "const llvm::DWARFDebugLine::LineTable *" to avoid the "(*line_table)->"
stuff below?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62570/new/
https://reviews.llvm.org/D62570
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
