aadsm added a comment. > However, now that I think about it, that is nonsense, because there is no way > for us to say to the user that "we failed to read some initial bytes, but > this is the memory contents after that". So just using process_vm_readv, and > finishing up with ptrace sounds fine to me.
The reason why I thought reading page by page still made sense in the ReadMemory is to cover for the situation where we cross 3 pages and the page in the middle is not readable. However, that might not be realistic to happen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
