aadsm marked an inline comment as done.
aadsm added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2738
+ if (!memory_buffer_sp) {
+ if (xfer_object == "auxv") {
+// *BSD impls should be able to do this too.
----------------
xiaobai wrote:
> labath wrote:
> > Given that this function is going to grow, it would be good to split it in
> > smaller chunks. Maybe move this code into something like
> > `ErrorOr<xfer_map::iterator> ReadObject(StringRef object)`?
> +1
>
> You could have smaller methods like "ParseAuxvPacket" and "ReadObject"
I'm actually trying to return an llvm::Expected so I can return a
`createStringError` that will have a message and an error code (as far as I can
see `ErrorOr`only allows to return an error code).
However, I can't figure out how to get both the error code and error message
from the `takeError()` function. I found `llvm::errorToErrorCode` and
`llvm::toString` but they both require to pass ownership of the error to them
so I can only use one of them.
Is the only way to use the `handleErrors` function that will give me access to
the underlying `ErrorInfo` where I can then call `convertToErrorCode` and
`getMessage` on it? Sounds overly complicated for something that's probably
simpler than this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62499/new/
https://reviews.llvm.org/D62499
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
