friss added inline comments.
================ Comment at: lldb/tools/argdumper/CMakeLists.txt:9 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(lldb-argdumper) +endif() ---------------- JDevlieghere wrote: > Why do we need this in the framework? Is it only there for testing? It is definitely use by our process launch code. ================ Comment at: lldb/tools/darwin-debug/CMakeLists.txt:6 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(lldb-argdumper) +endif() ---------------- JDevlieghere wrote: > Presumably this should be `darwin-debug`. But do we need it at all? I think it has come in handy a handful of times to debug some issues. It's not needed for LLDB to do its job though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62472/new/ https://reviews.llvm.org/D62472 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
