clayborg added a comment. Minor nit where we are storing name a ConstString but mangled name as "const char *". Fix if needed.
Would be good to verify performance doesn't regress from this somehow. Maybe having a large DWARF file with many types and accessing each type and making sure it is completed via the external AST. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:248 + clang::StorageClass storage = clang::SC_None; + const char *mangled_name = nullptr; + ConstString name; ---------------- Why is this stored as a "const char *" and "name" below as a ConstString? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62477/new/ https://reviews.llvm.org/D62477 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
