xiaobai added inline comments.
================ Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + + // We currently only support extracting values with Clang QualTypes. Do we + // care about others? ---------------- I don't see any references to clang in the below code. Is this still accurate? ================ Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1388 + + // value.SetContext (Value::eContextTypeClangType, return_value_type); + value.SetCompilerType(return_compiler_type); ---------------- Why is this commented out? If it's unneeded, please remove it ================ Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1811 + +// Windows doesn't use rbp +// Let this return false ---------------- nit: Windows-x86_64 doesn't use rbp Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
