JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM with a few small nits, even though I know you just moved the code.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:77
+ m_dwarf->GetDebugMapSymfile();
+ if (debug_map_sym_file == NULL) {
+ LineTable *line_table = sc.comp_unit->GetLineTable();
----------------
nullptr
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:80
+
+ if (line_table) {
+ LineTable::FileAddressRanges file_ranges;
----------------
`if (LineTable* line_table = )`
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:105
+
+ if (line_table) {
+ LineTable::FileAddressRanges file_ranges;
----------------
Same here
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62178/new/
https://reviews.llvm.org/D62178
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
