labath added a comment. BTW, there's no fundamental reason why a 64-bit lldb-server has to use instruction emulation for debugging arm32 binaries. Since all arm64 chips support hardware single stepping, we could just teach the arm32 native register context to issue PTRACE_SINGLESTEP commands when build in 64-bit mode, and increase debugging reliability while decreasing lldb-server size. (The same is probably also true for a 32-bit lldb-server running on a 64-bit kernel, but that's something that we would have to detect at runtime.)
Anyway, just an idea, this patch is fine. I was under the impression that arm64 defines __arm__, but obviously I was wrong. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62159/new/ https://reviews.llvm.org/D62159 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits