amccarth accepted this revision.
amccarth added a comment.
LGTM once you double-check the return value in the error case at the end of
`SymbolFileBreakpad::ParseUnwindRow`.
================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:472
+ if (!unwind_rules.empty())
+ LLDB_LOG(log, "Could not parse `{0}` as an unwind rule.", unwind_rules);
+ return true;
----------------
Should the function return `false` when there are leftover unparsable rules?
The other error cases seem to do that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61733/new/
https://reviews.llvm.org/D61733
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
