labath marked 3 inline comments as done. labath added inline comments.
================ Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:138-139 + DWARFDIE GetDIEFromUID(lldb::user_id_t uid); + lldb::user_id_t GetUIDFromDIE(DWARFBaseDIE die); + lldb::user_id_t GetUIDFromDIERef(DIERef ref); ---------------- clayborg wrote: > Maybe just overload these?: > ``` > lldb::user_id_t GetUID(DWARFBaseDIE die); > lldb::user_id_t GetUID(DIERef ref); > ``` Sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61648/new/ https://reviews.llvm.org/D61648 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
