On 02/05/2019 23:49, Saleem Abdulrasool via lldb-commits wrote:
Author: compnerd
Date: Thu May  2 14:49:29 2019
New Revision: 359832

URL: http://llvm.org/viewvc/llvm-project?rev=359832&view=rev
Log:
Initialization: move InstructionEmulation to full initialization

The debug server does not need to use the instruction emulation.  This helps
reduce the size of the final lldb-server binary by another ~100K (~1% savings).


I've reverted this patch because it's not correct. lldb-server definitely can use instruction emulation (see NativeProcessLinux.cpp for example).

What I was trying to say in the IRC discussion that resulted in this patch is that lldb-server does not need to use the non-host instruction emulation (so you definitely don't need to emulate MIPS, if you're targetting ARM, etc.).

So, what you could do is make the instruction emulation set target-dependent, similar to how we only include ObjectFileELF on elf platforms, and not all object file plugins.

pavel
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to