labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: source/API/SystemInitializerFull.cpp:132-133 + ObjectContainerBSDArchive::Initialize(); + ObjectContainerUniversalMachO::Initialize(); + ---------------- compnerd wrote: > labath wrote: > > xiaobai wrote: > > > You need to include the headers for these classes > > And remove them from `SystemInitializerCommon.h` > They never were in `SystemInitializerCommon.h` they are in SystemInitializerCommon.cpp (sorry, I typed the file name by memory, didn't double check). Please remove the include from there, and this is good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61360/new/ https://reviews.llvm.org/D61360 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
