[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: 
packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:32
+    self.expect("expr takePassByRef(p)",
+            substrs=['(int)', '= 11223344'])
----------------
friss wrote:
> If this test passes, we have a problem. The code modifies p.x to be 42, so 
> that what it should return.
The copy constructor does not actually copy and we are default constructing 
since it is pass by value, but that is probably too clever so I changed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61146/new/

https://reviews.llvm.org/D61146



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits